:recycle: adding error responses to profile endpoints

backend/lib/routes/profile/respond.js

@@ -61,10 +61,9 @@ module.exports = {
                 response_key_id: request.query.response_key_id,
                 val: request.query.val
             }
+            const allResponses = await profileService.saveResponseForProfile(profileId, responseToSave)
             
             try {
-                const allResponses = await profileService.saveResponseForProfile(profileId, responseToSave)
-                
                 // profileService.saveResponseForProfile() will return null if it exists
                 if(!allResponses){
                     throw new RangeError('Response already exists')

backend/lib/routes/profile/score.js

@@ -25,7 +25,12 @@ const validators = {
     // payload: true,
 }
 
-const responseSchemas = {}
+const responseSchemas = {
+    response: Joi.array().items(),
+    error: Joi.object({
+        error: Joi.string(),
+    }),
+}
 
 module.exports = {
     method: 'GET',
@@ -42,17 +47,21 @@ module.exports = {
             const profiles = await profileService.scoreProfilesFor(profileId)
 
             try {
-                return {
+                if(!profiles){
+                    throw new RangeError('Unable to score profiles')
+                }
+                
+                return h.response({
                     ok: true,
                     handler: pluginConfig.handlerType,
                     data: profiles,
-                }
+                }).code(200)
             } catch (err) {
-                return {
+                return h.response({
                     ok: false,
                     handler: pluginConfig.handlerType,
                     data: { error: `${err}` },
-                }
+                }).code(409)
             }
         },
 
@@ -64,11 +73,18 @@ module.exports = {
 
         /** Validate the server response */
         response: {
-            schema: Joi.object({
-                ok: Joi.bool(),
-                handler: Joi.string(),
-                data: Joi.array().items(),
-            }),
+            status: {
+                200: Joi.object({
+                    ok: Joi.bool(),
+                    handler: Joi.string(),
+                    data: responseSchemas.response,
+                }),
+                409: Joi.object({
+                    ok: Joi.bool(),
+                    handler: Joi.string(),
+                    data: responseSchemas.error,
+                }),
+            }
         },
     },
 }

backend/lib/routes/profile/update.js

@@ -46,7 +46,7 @@ module.exports = {
         /** Protect this route with authentication? */
         auth: false,
 
-        handler: async function (request) {
+        handler: async function (request, h) {
             const { profileService } = request.services()
             const profileId = request.params.profile_id
 
@@ -54,21 +54,25 @@ module.exports = {
             
             /** Grab payload info */
             const res = request.payload
-
-            const updatedResponses =
-                await profileService.updateResponsesInProfile(profileId, res)
             try {
-                return {
+                const updatedResponses = await profileService.updateResponsesInProfile(profileId, res)
+
+                if(!updatedResponses) {
+                    throw new RangeError(
+                        'Response not updated',
+                    )
+                }
+                return h.response({
                     ok: true,
                     handler: pluginConfig.handlerType,
                     data: updatedResponses,
-                }
+                }).code(200)
             } catch (err) {
-                return {
+                return h.response({
                     ok: false,
                     handler: pluginConfig.handlerType,
                     data: { error: `${err}` },
-                }
+                }).code(409)
             }
         },
 
@@ -81,12 +85,12 @@ module.exports = {
         /** Validate the server response */
         response: {
             status: {
-                201: Joi.object({
+                200: Joi.object({
                     ok: Joi.bool(),
                     handler: Joi.string(),
                     data: responseSchemas.responses,
                 }),
-                500: Joi.object({
+                409: Joi.object({
                     ok: Joi.bool(),
                     handler: Joi.string(),
                     data: responseSchemas.error,