:recycle: Refactored filtering by presence and duration

backend/lib/services/filter.js

@@ -29,34 +29,35 @@ module.exports = class FilterService extends Schmervice.Service {
         })
     }
 
-    byPresence(profileList, presence) {
-        const matchingProfiles = []
+    _filterByAspect(profileList, aspect, responseKeyId) {
+        const responseIndex = new Map()
+        // NOTE: Initializes a  hash map so that we can filter
+        // based off of initially nested responses
         for (const profile of profileList) {
             for (const response of profile.responses) {
-                if (
-                    response.response_key_id === 15 &&
-                    response.val === presence
-                ) {
-                    matchingProfiles.push(profile)
+                const key = `${response.response_key_id}-${response.val}`
+                if (!responseIndex.has(key)) {
+                    responseIndex.set(key, [])
                 }
+                responseIndex.get(key).push(profile)
             }
         }
+        // NOTE: Then utilizes the responseKeyId, and
+        // aspect(either presence or duration)
+        // to look up which profiles have matching responses
+        const key = `${responseKeyId}-${aspect}`
+        const matchingProfiles = responseIndex.get(key) || []
         return matchingProfiles
     }
 
+    byPresence(profileList, presence) {
+        const responseKeyId = 15
+        return this._filterByAspect(profileList, presence, responseKeyId)
+    }
+
     byDuration(profileList, duration) {
-        const matchingProfiles = []
-        for (const profile of profileList) {
-            for (const response of profile.responses) {
-                if (
-                    response.response_key_id === 14 &&
-                    response.val === duration
-                ) {
-                    matchingProfiles.push(profile)
-                }
-            }
-        }
-        return matchingProfiles
+        const responseKeyId = 14
+        return this._filterByAspect(profileList, duration, responseKeyId)
     }
 
     // TODO: Implement filtering by matching certification