:recycle: Cleaning up refactor a bit, needs another pass

backend/lib/routes/membership/active.js

@@ -75,19 +75,12 @@ module.exports = {
                 groupings.map(grouping => grouping.grouping_id),
             )
 
-            // NOTE: Current implementation works okay, it only reveals the targetID's
-            // hidden info on the page currently, it does NOT reveal OUR OWN information
-            // to ourselves when revealed
-
             /**
              * Heavily process the result by storing just a profile_id
              * and attach complete profiles
              */
-            // NOTE: only returns the pId for the target
             let pIds = groupings.reduce((ids, grouping) => {
                 grouping.profiles.forEach(p => {
-                    // you'd think to comment out here, but it still only returns CompleteProfile of target
-                    // pIds would be both currentProfile id and target id though
                     if (p.profile_id == profileId) return 
                     ids.push(p.profile_id)
                     grouping.profile = p.profile_id
@@ -95,14 +88,12 @@ module.exports = {
                 delete grouping.profiles
                 return ids
             }, [])
-            console.log('pIds :=>', pIds) // only returns single array of target id
             /** Assemble complete profiles to reference and pass */
             const completedProfiles = await profileService.getProfilesFor(
                 pIds,
                 'participant',
                 false,
             )
-
             // NOTE: Doesn't rely on profile reveal field to get reveal tags
             const getGroupingRevealTags = async () => {
                 const groupingRevealTags = []
@@ -142,7 +133,6 @@ module.exports = {
 
             const completedProfilesWithRevealedInfo = await getRevealInfo()
 
-            // ISSUE: renders target ID but not currentProfileID in ChatView.vue
             const reformattedGroupings = groupings.map(g => {
                 completedProfilesWithRevealedInfo.forEach(p => {
                     g.profile = g.profile == p.profile_id ? p : g.profile
@@ -152,7 +142,7 @@ module.exports = {
                 )
                 return g
             })
-            console.log('reformattedGroupings :=>', reformattedGroupings)
+
             try {
                 return {
                     ok: true,

frontend/src/views/ChatView.vue

@@ -15,16 +15,18 @@ main.view--chat
                 button(@click='reveal(8)') reveal my email
                 // TODO: Remove later, only for testing
                 button(@click='checkData()') check data
-            p you revealed:
-                span(v-if="grouping.revealed[profile.id.value]")
-                    ul(v-for="reveal in grouping.revealed[profile.id.value]")
-                        li {{ reveal.description }}: {{ profile._profile[reveal.description] }}
-            p they revealed:
+            span(v-if="grouping.revealed[profile.id.value]")
+                p you revealed: 
+                ul(v-for="reveal in grouping.revealed[profile.id.value]")
+                    li {{ reveal.description }}
             span(v-if="grouping.revealed[target.profile_id]")
+                p they revealed:
                 ul(v-for="reveal in grouping.revealed[target.profile_id]")
                     li {{ reveal.description }}: {{ target[reveal.description] }}
-            ul(v-for="revealed in grouping.revealedFromNotification")
-                li(v-if="revealed[revealed.tag_description] !== profile._profile[revealed.tag_description]") {{ revealed.tag_description }}: {{ revealed[revealed.tag_description] }}
+            span(v-else-if="grouping.revealedFromNotification.length")
+                p they revealed:
+                ul(v-for="revealed in grouping.revealedFromNotification")
+                    li(v-if="revealed[revealed.tag_description] !== profile._profile[revealed.tag_description]") {{ revealed.tag_description }}: {{ revealed[revealed.tag_description] }}
 
     article
         template(v-if='isLoading')