:recycle: trim down validate session route further

backend/lib/routes/user/validate-session.js

@@ -54,20 +54,17 @@ module.exports = {
                 const sessionTokenIsValid = userService.validateToken(
                     userSession.sessionToken,
                 )
-                if (sessionTokenIsValid.message) {
-                    throw new Error(sessionTokenIsValid.message)
+                if (!sessionTokenIsValid) {
+                    throw new Error(
+                        `Could not validate session token: ${userSession.sessionToken}`,
+                    )
                 }
-                const validatedSessionInfo = sessionTokenIsValid
-                    ? userSession
-                    : { ...sessionTokenIsValid }
-
-                if (validatedSessionInfo?.email)
+                if (userSession?.email)
                     throw new Error(
                         `Could not validate token based on payload: ${request.payload}`,
                     )
-
                 const user = await userService.findByUserEmail(
-                    validatedSessionInfo.email,
+                    userSession.email,
                 )
                 const type = user.is_poster === 1 ? 'poster' : 'seeker'
                 const profiles = await profileService.getCompleteProfilesFor(
@@ -80,7 +77,7 @@ module.exports = {
                     ok: true,
                     handler: pluginConfig.handlerType,
                     data: {
-                        ...validatedSessionInfo,
+                        ...userSession,
                         profileId: profileId,
                     },
                 }

backend/lib/services/user.js

@@ -240,11 +240,7 @@ module.exports = class UserService extends Schmervice.Service {
      */
     validateToken(token) {
         const key = process.env.APP_SECRET
-        try {
-            return JWT.verify(token, key)
-        } catch (err) {
-            return { payload: null, message: err.message }
-        }
+        return JWT.verify(token, key)
     }
     removeSession(hashedSessionToken) {
         const userSession = this.activeSessions[hashedSessionToken]