:recycle: tweak login cookie | don't pass session key string around just set default arg

frontend/src/router/guards.js

@@ -15,9 +15,7 @@ async function log(to) {
 }
 
 const loginIfToken = async () => {
-    const sessionData = await authenticator.verifySessionCookie(
-        'siimee_session',
-    )
+    const sessionData = await authenticator.verifySessionCookie()
     if (
         sessionData?.profileId &&
         sessionData?.sessionToken &&

frontend/src/services/auth.service.js

@@ -25,20 +25,16 @@ class Authenticator {
             prev[name] = value.join('=')
             return prev
         }, {})
-        const cookieVal =
-            cookieKey in cookies ? cookies[`${cookieKey}`] : undefined
-        return cookieVal
+        return cookies[cookieKey]
     }
-    async verifySessionCookie(sessionCookie) {
-        const hashedAccessToken = this.grabStoredCookie(sessionCookie)
+    async verifySessionCookie(sessionCookieKey = 'siimee_session') {
+        const hashedAccessToken = this.grabStoredCookie(sessionCookieKey)
         if (!hashedAccessToken)
             return console.warn('WARNING :=> accessToken is not defined')
         const validatedToken = await this.validateSession(hashedAccessToken)
-        if (validatedToken.error) {
-            console.error('ERROR :=>', validatedToken.error)
-        } else {
-            return validatedToken
-        }
+        if (validatedToken.error)
+            return console.error('ERROR :=>', validatedToken.error)
+        return validatedToken
     }
 }
 const authenticator = new Authenticator()

frontend/src/views/LoginView.vue

@@ -55,7 +55,7 @@ export default {
             if (sessionInfo.emailSentSuccessfully) {
                 this.emailSentSuccessfully = true
             }
-            document.cookie = `siimee_session=${sessionInfo.hashedSessionToken}; max-age=600; path=/`
+            document.cookie = `siimee_session=${sessionInfo.hashedSessionToken}; max-age=600; path=/; SameSite=Lax`
         },
     },
 }

frontend/src/views/OnboardingView.vue

@@ -60,9 +60,7 @@ export default {
         // TODO: Troubleshoot bug where not all responses are returned at SurveyCompleteView
         this.survey = await surveyFactory.createSurvey()
         try {
-            const sessionData = await authenticator.verifySessionCookie(
-                'siimee_session',
-            )
+            const sessionData = await authenticator.verifySessionCookie()
             if (sessionData) {
                 this.responses = this.formatResponses(
                     currentProfile._profile.responses,
@@ -115,7 +113,7 @@ export default {
                 )
                 currentProfile._profile.responses = this.responses
                 try {
-                    await authenticator.verifySessionCookie('siimee_session')
+                    await authenticator.verifySessionCookie()
                 } catch (err) {
                     this.currentStep = 0
                     this.goToStep(this.currentStep)

frontend/src/views/VerifyView.vue

@@ -14,8 +14,7 @@ export default {
         try {
             this.isHashInUrl(hash)
             await this.verifyActiveSession(hash)
-            const sessionData =
-                await authenticator.verifySessionCookie('siimee_session')
+            const sessionData = await authenticator.verifySessionCookie()
             currentProfile.login(
                 sessionData.profileId,
                 this.$waveui.notify,