:white_check_mark: Finished editing membership /<profile_id> test

backend/lib/routes/membership/active.js

@@ -123,7 +123,6 @@ module.exports = {
                           'reveal',
                       )
                     : undefined
-            console.log('revealTags :=>', revealTags)
 
             /** If the revealTags exist, the completedProfile's hidden info is
              * removed and replaced with the completedProfile's user information
@@ -134,12 +133,10 @@ module.exports = {
                       completedProfiles.map(p => p.user_id),
                   )
                 : undefined
-            console.log('user :=>', user)
 
             // TODO: Refactor this. Is it safe to always use completedProfiles[0]?
             if (revealTags && user) {
                 revealTags.forEach(t => {
-                    console.log('t :=>', t)
                     if (!t.tag.tag_description) return
                     completedProfiles[0][t.tag.tag_description] =
                         user[t.tag.tag_description]

backend/lib/services/profile/index.js

@@ -372,12 +372,8 @@ module.exports = class ProfileService extends Schmervice.Service {
      * @param {object}
      */
     async getTagsFor(profileId, groupingId, category) {
-        console.log('profileId :=>', profileId) // [ 1, 2 ]
-        console.log('groupingId :=>', groupingId) // [ 1 ]
-        console.log('category :=>', category) // 'reveal'
         const { TagAssociation } = this.server.models()
         await this._setTagLookup()
-        console.log('this.tagLookup :=>', this.tagLookup) // {}
         let associations = []
         if (!profileId.length || !groupingId.length) {
             return associations
@@ -388,20 +384,18 @@ module.exports = class ProfileService extends Schmervice.Service {
                       .where('grouping_id', groupingId)
                       .andWhere('profile_id', profileId)
                 : await TagAssociation.query().andWhere('profile_id', profileId)
-            // filter doesn't fire in tests (incorrect format?)
-            return associations.map(assoc => ({
-                ...assoc,
-                tag: this.tagLookup[assoc.tag_id]
-                    ? {}
-                    : this.tagLookup[assoc.tag_id],
-            }))
-            /*
+            return associations
+                .map(assoc => ({
+                    ...assoc,
+                    tag: !this.tagLookup[assoc.tag_id]
+                        ? {}
+                        : this.tagLookup[assoc.tag_id],
+                }))
                 .filter(tagWithAssoc => {
                     return category
                         ? tagWithAssoc.tag.tag_category == category
                         : true
                 })
-            */
         }
     }
 

backend/tests/membership.spec.js

@@ -16,7 +16,6 @@ const Membership = require('../lib/models/membership')
 const Tag = require('../lib/models/tag')
 const TagAssociation = require('../lib/models/tag-association')
 const User = require('../lib/models/user')
-const ZipCode = require('../lib/models/zip-code')
 const Aspect = require('../lib/models/aspect')
 const AspectLabel = require('../lib/models/aspect_label')
 
@@ -93,22 +92,29 @@ const mockReturn = {
             grouping_id: 1,
             tag_id: 7,
             is_deleted: 0,
-            tag: {
-                tag_category: 'reveal',
-            },
         },
         {
             tag_association_id: 2,
             profile_id: 1,
             grouping_id: 1,
-            tag_id: 7,
+            tag_id: 8,
             is_deleted: 0,
-            tag: {
-                tag_category: 'reveal',
-            },
         },
     ],
-    tags: [],
+    tags: [
+        {
+            tag_id: 7,
+            tag_category: 'reveal',
+            tag_description: 'user_name',
+            is_active: 1,
+        },
+        {
+            tag_id: 8,
+            tag_category: 'reveal',
+            tag_description: 'user_email',
+            is_active: 1,
+        },
+    ],
     labels: [
         { aspect_id: 1, a: 100, b: 100 },
         { aspect_id: 2, a: 100, b: 200 },
@@ -164,9 +170,6 @@ test('path /<profile_id> should return ok', async t => {
         User,
     })
 
-    // server.registerService(ProfileService)
-    // server.registerService(MembershipService)
-    // server.registerService(UserService)
     /**
      * Register Routes and Services as usual
      */
@@ -239,15 +242,11 @@ test('path /<profile_id> should return ok', async t => {
     const { payload } = await server.inject(pathToTest)
     const res = JSON.parse(payload)
 
-    t.log('res :=>', res)
     t.deepEqual(res.ok, true)
     t.deepEqual(res.data.length, 1)
-
-    /*
     t.deepEqual(res.data[0].grouping_id, mockReturn.groupings[0].grouping_id)
     t.deepEqual(
         res.data[0].profile.user_name,
         mockReturn.groupings[0].profile.user_name,
     )
-    */
 })