:recycle: refactor to use profile_id in membershios | adding a lot more response mock data

backend/db/migrations/20210527174440_create_memberships_table.js

@@ -1,7 +1,7 @@
 exports.up = function (knex) {
     return knex.schema.createTable('memberships', function (table) {
         table.increments('membership_id').primary()
-        table.integer('user_id').notNullable() // From
+        table.integer('profile_id').notNullable() // From
         table.integer('grouping_id').notNullable() // To
         table.string('membership_type', 128).notNullable() // Don't over normalize
         table.boolean('can_edit').notNullable()

backend/db/mock.js

@@ -35,14 +35,29 @@ module.exports = {
             is_admin: false,
             is_poster: false,
         },
+        {
+            user_id: 6,
+            user_name: 'monkey',
+            user_email: 'catcat@cats.com',
+            is_admin: false,
+            is_poster: true,
+        },
+        {
+            user_id: 7,
+            user_name: 'lady',
+            user_email: 'really_just@allcats.com',
+            is_admin: false,
+            is_poster: false,
+        },
     ],
     profiles: [
-        { profile_id: 1, user_id: 2 },
+        { profile_id: 1, user_id: 1 },
         { profile_id: 2, user_id: 2 },
         { profile_id: 3, user_id: 3 },
         { profile_id: 4, user_id: 4 },
-        { profile_id: 5, user_id: 4 },
-        { profile_id: 6, user_id: 4 },
+        { profile_id: 5, user_id: 5 },
+        { profile_id: 6, user_id: 6 },
+        { profile_id: 7, user_id: 7 },
     ],
     response_keys: [
         {
@@ -59,7 +74,7 @@ module.exports = {
         },
         {
             response_key_id: 3,
-            response_key_category: 'grit',
+            response_key_category: 'bravery',
             response_key_prompt: 'what is your quest',
             response_key_description: null,
         },
@@ -70,42 +85,585 @@ module.exports = {
                 'what is the average flight speed of an unladen swallow',
             response_key_description: null,
         },
+        {
+            response_key_id: 5,
+            response_key_category: 'grit',
+            response_key_prompt: 'name what is your',
+            response_key_description: null,
+        },
+        {
+            response_key_id: 6,
+            response_key_category: 'honesty',
+            response_key_prompt: 'what is your favorite color',
+            response_key_description: null,
+        },
+        {
+            response_key_id: 7,
+            response_key_category: 'respect',
+            response_key_prompt: 'what is your quest',
+            response_key_description: null,
+        },
+        {
+            response_key_id: 8,
+            response_key_category: 'empathy',
+            response_key_prompt:
+                'flight speed of an unladen swallow what is the average',
+            response_key_description: null,
+        },
+        {
+            response_key_id: 9,
+            response_key_category: 'respect',
+            response_key_prompt: 'what is your name',
+            response_key_description: null,
+        },
+        {
+            response_key_id: 10,
+            response_key_category: 'openness',
+            response_key_prompt: 'color what is your favorite',
+            response_key_description: null,
+        },
+        {
+            response_key_id: 11,
+            response_key_category: 'bravery',
+            response_key_prompt: 'quest what is your ',
+            response_key_description: null,
+        },
+        {
+            response_key_id: 12,
+            response_key_category: 'honesty',
+            response_key_prompt:
+                'what is the average flight speed of an unladen swallow',
+            response_key_description: null,
+        },
+        {
+            response_key_id: 13,
+            response_key_category: 'locationPref',
+            response_key_prompt: 'where are you looking to work',
+            response_key_description: null,
+        },
+        {
+            response_key_id: 14,
+            response_key_category: 'languagePref',
+            response_key_prompt: 'languages are you proficient in',
+            response_key_description: null,
+        },
+        {
+            response_key_id: 15,
+            response_key_category: 'durationPref',
+            response_key_prompt: 'what kind of schedule are you looking for',
+            response_key_description: null,
+        },
     ],
     responses: [
-        { response_id: 1, profile_id: 2, response_key_id: 2, val: '80' },
-        { response_id: 2, profile_id: 2, response_key_id: 1, val: '70' },
-        { response_id: 3, profile_id: 2, response_key_id: 1, val: '50' },
+        {
+            response_id: 1,
+            profile_id: 1,
+            response_key_id: 0,
+            val: '160',
+        },
+        {
+            response_id: 2,
+            profile_id: 1,
+            response_key_id: 1,
+            val: '140',
+        },
+        {
+            response_id: 3,
+            profile_id: 1,
+            response_key_id: 2,
+            val: '180',
+        },
         {
             response_id: 4,
-            profile_id: 2,
+            profile_id: 1,
             response_key_id: 3,
-            val: 'I am actually a very experienced cat.',
+            val: '120',
         },
         {
             response_id: 5,
+            profile_id: 1,
+            response_key_id: 4,
+            val: '140',
+        },
+        {
+            response_id: 6,
+            profile_id: 1,
+            response_key_id: 5,
+            val: '120',
+        },
+        {
+            response_id: 7,
+            profile_id: 1,
+            response_key_id: 6,
+            val: '120',
+        },
+        {
+            response_id: 8,
+            profile_id: 1,
+            response_key_id: 7,
+            val: '120',
+        },
+        {
+            response_id: 9,
+            profile_id: 1,
+            response_key_id: 8,
+            val: '140',
+        },
+        {
+            response_id: 10,
+            profile_id: 1,
+            response_key_id: 9,
+            val: '200',
+        },
+        {
+            response_id: 11,
+            profile_id: 1,
+            response_key_id: 10,
+            val: '200',
+        },
+        {
+            response_id: 12,
+            profile_id: 1,
+            response_key_id: 11,
+            val: '160',
+        },
+        {
+            response_id: 13,
+            profile_id: 2,
+            response_key_id: 0,
+            val: '180',
+        },
+        {
+            response_id: 14,
+            profile_id: 2,
+            response_key_id: 1,
+            val: '200',
+        },
+        {
+            response_id: 15,
+            profile_id: 2,
+            response_key_id: 2,
+            val: '120',
+        },
+        {
+            response_id: 16,
+            profile_id: 2,
+            response_key_id: 3,
+            val: '140',
+        },
+        {
+            response_id: 17,
+            profile_id: 2,
+            response_key_id: 4,
+            val: '180',
+        },
+        {
+            response_id: 18,
+            profile_id: 2,
+            response_key_id: 5,
+            val: '180',
+        },
+        {
+            response_id: 19,
+            profile_id: 2,
+            response_key_id: 6,
+            val: '120',
+        },
+        {
+            response_id: 20,
+            profile_id: 2,
+            response_key_id: 7,
+            val: '140',
+        },
+        {
+            response_id: 21,
+            profile_id: 2,
+            response_key_id: 8,
+            val: '180',
+        },
+        {
+            response_id: 22,
+            profile_id: 2,
+            response_key_id: 9,
+            val: '140',
+        },
+        {
+            response_id: 23,
+            profile_id: 2,
+            response_key_id: 10,
+            val: '160',
+        },
+        {
+            response_id: 24,
+            profile_id: 2,
+            response_key_id: 11,
+            val: '180',
+        },
+        {
+            response_id: 25,
+            profile_id: 3,
+            response_key_id: 0,
+            val: '160',
+        },
+        {
+            response_id: 26,
+            profile_id: 3,
+            response_key_id: 1,
+            val: '140',
+        },
+        {
+            response_id: 27,
+            profile_id: 3,
+            response_key_id: 2,
+            val: '140',
+        },
+        {
+            response_id: 28,
             profile_id: 3,
             response_key_id: 3,
-            val: 'I am not a person but I need a job',
+            val: '200',
         },
         {
-            response_id: 6,
+            response_id: 29,
+            profile_id: 3,
+            response_key_id: 4,
+            val: '180',
+        },
+        {
+            response_id: 30,
+            profile_id: 3,
+            response_key_id: 5,
+            val: '200',
+        },
+        {
+            response_id: 31,
+            profile_id: 3,
+            response_key_id: 6,
+            val: '160',
+        },
+        {
+            response_id: 32,
+            profile_id: 3,
+            response_key_id: 7,
+            val: '200',
+        },
+        {
+            response_id: 33,
+            profile_id: 3,
+            response_key_id: 8,
+            val: '120',
+        },
+        {
+            response_id: 34,
+            profile_id: 3,
+            response_key_id: 9,
+            val: '180',
+        },
+        {
+            response_id: 35,
+            profile_id: 3,
+            response_key_id: 10,
+            val: '120',
+        },
+        {
+            response_id: 36,
+            profile_id: 3,
+            response_key_id: 11,
+            val: '200',
+        },
+        {
+            response_id: 37,
+            profile_id: 4,
+            response_key_id: 0,
+            val: '140',
+        },
+        {
+            response_id: 38,
+            profile_id: 4,
+            response_key_id: 1,
+            val: '180',
+        },
+        {
+            response_id: 39,
+            profile_id: 4,
+            response_key_id: 2,
+            val: '160',
+        },
+        {
+            response_id: 40,
             profile_id: 4,
             response_key_id: 3,
-            val: 'Just a job that needs grit',
+            val: '160',
         },
-        { response_id: 7, profile_id: 4, response_key_id: 2, val: '30' },
-        { response_id: 8, profile_id: 4, response_key_id: 1, val: '100' },
         {
-            response_id: 9,
+            response_id: 41,
+            profile_id: 4,
+            response_key_id: 4,
+            val: '140',
+        },
+        {
+            response_id: 42,
+            profile_id: 4,
+            response_key_id: 5,
+            val: '140',
+        },
+        {
+            response_id: 43,
+            profile_id: 4,
+            response_key_id: 6,
+            val: '120',
+        },
+        {
+            response_id: 44,
+            profile_id: 4,
+            response_key_id: 7,
+            val: '140',
+        },
+        {
+            response_id: 45,
+            profile_id: 4,
+            response_key_id: 8,
+            val: '120',
+        },
+        {
+            response_id: 46,
+            profile_id: 4,
+            response_key_id: 9,
+            val: '120',
+        },
+        {
+            response_id: 47,
+            profile_id: 4,
+            response_key_id: 10,
+            val: '200',
+        },
+        {
+            response_id: 48,
+            profile_id: 4,
+            response_key_id: 11,
+            val: '140',
+        },
+        {
+            response_id: 49,
+            profile_id: 5,
+            response_key_id: 0,
+            val: '200',
+        },
+        {
+            response_id: 50,
+            profile_id: 5,
+            response_key_id: 1,
+            val: '160',
+        },
+        {
+            response_id: 51,
+            profile_id: 5,
+            response_key_id: 2,
+            val: '200',
+        },
+        {
+            response_id: 52,
+            profile_id: 5,
+            response_key_id: 3,
+            val: '140',
+        },
+        {
+            response_id: 53,
+            profile_id: 5,
+            response_key_id: 4,
+            val: '180',
+        },
+        {
+            response_id: 54,
+            profile_id: 5,
+            response_key_id: 5,
+            val: '200',
+        },
+        {
+            response_id: 55,
+            profile_id: 5,
+            response_key_id: 6,
+            val: '200',
+        },
+        {
+            response_id: 56,
+            profile_id: 5,
+            response_key_id: 7,
+            val: '180',
+        },
+        {
+            response_id: 57,
+            profile_id: 5,
+            response_key_id: 8,
+            val: '140',
+        },
+        {
+            response_id: 58,
+            profile_id: 5,
+            response_key_id: 9,
+            val: '140',
+        },
+        {
+            response_id: 59,
+            profile_id: 5,
+            response_key_id: 10,
+            val: '180',
+        },
+        {
+            response_id: 60,
             profile_id: 5,
+            response_key_id: 11,
+            val: '160',
+        },
+        {
+            response_id: 61,
+            profile_id: 6,
+            response_key_id: 0,
+            val: '120',
+        },
+        {
+            response_id: 62,
+            profile_id: 6,
+            response_key_id: 1,
+            val: '180',
+        },
+        {
+            response_id: 63,
+            profile_id: 6,
+            response_key_id: 2,
+            val: '160',
+        },
+        {
+            response_id: 64,
+            profile_id: 6,
+            response_key_id: 3,
+            val: '120',
+        },
+        {
+            response_id: 65,
+            profile_id: 6,
+            response_key_id: 4,
+            val: '140',
+        },
+        {
+            response_id: 66,
+            profile_id: 6,
+            response_key_id: 5,
+            val: '140',
+        },
+        {
+            response_id: 67,
+            profile_id: 6,
+            response_key_id: 6,
+            val: '140',
+        },
+        {
+            response_id: 68,
+            profile_id: 6,
+            response_key_id: 7,
+            val: '160',
+        },
+        {
+            response_id: 69,
+            profile_id: 6,
+            response_key_id: 8,
+            val: '180',
+        },
+        {
+            response_id: 70,
+            profile_id: 6,
+            response_key_id: 9,
+            val: '200',
+        },
+        {
+            response_id: 71,
+            profile_id: 6,
+            response_key_id: 10,
+            val: '180',
+        },
+        {
+            response_id: 72,
+            profile_id: 6,
+            response_key_id: 11,
+            val: '160',
+        },
+        {
+            response_id: 73,
+            profile_id: 7,
+            response_key_id: 0,
+            val: '160',
+        },
+        {
+            response_id: 74,
+            profile_id: 7,
+            response_key_id: 1,
+            val: '140',
+        },
+        {
+            response_id: 75,
+            profile_id: 7,
+            response_key_id: 2,
+            val: '140',
+        },
+        {
+            response_id: 76,
+            profile_id: 7,
             response_key_id: 3,
-            val: 'This job posting is awful',
+            val: '160',
+        },
+        {
+            response_id: 77,
+            profile_id: 7,
+            response_key_id: 4,
+            val: '200',
+        },
+        {
+            response_id: 78,
+            profile_id: 7,
+            response_key_id: 5,
+            val: '120',
+        },
+        {
+            response_id: 79,
+            profile_id: 7,
+            response_key_id: 6,
+            val: '160',
+        },
+        {
+            response_id: 80,
+            profile_id: 7,
+            response_key_id: 7,
+            val: '160',
+        },
+        {
+            response_id: 81,
+            profile_id: 7,
+            response_key_id: 8,
+            val: '160',
+        },
+        {
+            response_id: 82,
+            profile_id: 7,
+            response_key_id: 9,
+            val: '120',
+        },
+        {
+            response_id: 83,
+            profile_id: 7,
+            response_key_id: 10,
+            val: '180',
+        },
+        {
+            response_id: 84,
+            profile_id: 7,
+            response_key_id: 11,
+            val: '180',
         },
     ],
     memberships: [
         {
             membership_id: 1,
-            user_id: 1,
+            profile_id: 1,
             grouping_id: 1,
             membership_type: '_admin',
             can_edit: true,
@@ -113,7 +671,7 @@ module.exports = {
         },
         {
             membership_id: 2,
-            user_id: 1,
+            profile_id: 1,
             grouping_id: 2,
             membership_type: 'recruiter',
             can_edit: true,
@@ -121,7 +679,7 @@ module.exports = {
         },
         {
             membership_id: 3,
-            user_id: 1,
+            profile_id: 1,
             grouping_id: 3,
             membership_type: 'participant',
             can_edit: false,
@@ -129,7 +687,7 @@ module.exports = {
         },
         {
             membership_id: 4,
-            user_id: 2,
+            profile_id: 2,
             grouping_id: 3,
             membership_type: 'participant',
             can_edit: false,
@@ -137,7 +695,7 @@ module.exports = {
         },
         {
             membership_id: 5,
-            user_id: 4,
+            profile_id: 4,
             grouping_id: 4,
             membership_type: 'participant',
             can_edit: false,
@@ -145,7 +703,7 @@ module.exports = {
         },
         {
             membership_id: 6,
-            user_id: 2,
+            profile_id: 2,
             grouping_id: 4,
             membership_type: 'participant',
             can_edit: false,
@@ -153,7 +711,7 @@ module.exports = {
         },
         {
             membership_id: 7,
-            user_id: 3,
+            profile_id: 3,
             grouping_id: 5,
             membership_type: 'participant',
             can_edit: false,
@@ -161,7 +719,7 @@ module.exports = {
         },
         {
             membership_id: 8,
-            user_id: 1,
+            profile_id: 1,
             grouping_id: 5,
             membership_type: 'participant',
             can_edit: false,

backend/db/seeds/04-responses.js

@@ -1,10 +1,11 @@
-const mock = require('../mock');
+const mock = require('../mock')
 
-exports.seed = function(knex) {
-  // Deletes ALL existing entries
-  return knex('responses').truncate()
-    .then(function () {
-      // Inserts seed entries
-      return knex('responses').insert(mock.responses);
-    });
-};
+exports.seed = function (knex) {
+    // Deletes ALL existing entries
+    return knex('responses')
+        .truncate()
+        .then(function () {
+            // Inserts seed entries
+            return knex('responses').insert(mock.responses)
+        })
+}

backend/db/survey-generator.js

@@ -1,3 +1,4 @@
+const fs = require('fs')
 const similarity = require('compute-cosine-similarity')
 const magic = 1000 // Multiply cosine similary by this
 
@@ -160,8 +161,8 @@ const generateDummyProfiles = (count, startFrom) => {
     return profiles
 }
 
-const generatedSeekers = generateDummyProfiles(100, 0)
-const generatedProviders = generateDummyProfiles(80, generatedSeekers.length)
+const generatedSeekers = generateDummyProfiles(20, 0)
+const generatedProviders = generateDummyProfiles(5, generatedSeekers.length)
 const balanceSeekersAndProviders = (seekers, providers) => {
     let diff = 0
     let smallerList = null
@@ -242,7 +243,8 @@ if (generatedSeekers.length == generatedProviders.length) {
                   .indexOf(generatedProviders[0].otp.id) + 1
             : generatedProviders[0].otp,
     )
-    console.log(generatedProviders[0].matchPref.map(m => m.id))
+    // console.log(generatedProviders[0].matchPref.map(m => m.id))
+    console.log(generatedProviders[0])
 
     console.log('---')
 
@@ -257,5 +259,6 @@ if (generatedSeekers.length == generatedProviders.length) {
                   .indexOf(generatedSeekers[0].otp.id) + 1
             : generatedSeekers[0].otp,
     )
-    console.log(generatedSeekers[0].matchPref.map(m => m.id))
+    console.log(generatedSeekers[0])
+    // console.log(generatedSeekers[0].matchPref.map(m => m.id))
 }

backend/lib/models/membership.js

@@ -8,7 +8,7 @@ module.exports = class Membership extends Schwifty.Model {
     static get joiSchema() {
         return Joi.object({
             membership_id: Joi.number(),
-            user_id: Joi.number().required(),
+            profile_id: Joi.number().required(),
             grouping_id: Joi.number().allow(null),
             membership_type: Joi.string().required(),
             can_edit: Joi.boolean().required(),

backend/lib/routes/membership/active.js

@@ -34,7 +34,7 @@ const responseSchemas = {
 
 module.exports = {
     method: 'GET',
-    path: '/active/{user_id}',
+    path: '/active/{profile_id}',
     options: {
         ...pluginConfig.docs,
         tags: ['api'],
@@ -43,8 +43,10 @@ module.exports = {
 
         handler: async function (request, h) {
             const { membershipService } = request.services()
-            const userId = request.params.user_id
-            const groupings = await membershipService.findGroupingsById(userId)
+            const profileId = request.params.profile_id
+            const groupings = await membershipService.findGroupingsById(
+                profileId,
+            )
             try {
                 return {
                     ok: true,

backend/lib/routes/membership/join.js

@@ -11,7 +11,7 @@ const pluginConfig = {
 const validators = {
     join: {
         payload: Joi.object({
-            user_id: Joi.number().required(),
+            profile_id: Joi.number().required(),
             target_id: Joi.number().allow(null),
             grouping_id: Joi.number().allow(null),
             grouping_name: Joi.string().allow(null),
@@ -52,7 +52,7 @@ module.exports = {
 
                 /** User membership service method to create membership */
                 const memberships = await membershipService.joinGrouping(
-                    res.user_id,
+                    res.profile_id,
                     res.target_id,
                     groupingToWrite,
                     role,

backend/lib/services/membership.js

@@ -7,14 +7,17 @@ module.exports = class MembershipService extends Schmervice.Service {
 
     /**
      * Internal method to get list of grouping_ids for this user
-     * @param {number} userId
+     * @param {number} profileId
      * @returns {Array} List of all grouping_ids for user
      */
-    async _getGroupIdsForUserId(userId) {
+    async _getGroupIdsForProfileId(profileId) {
         const { Membership } = this.server.models()
 
         /** Grab every Membership associated with this id */
-        const allMemberships = await Membership.query().where('user_id', userId)
+        const allMemberships = await Membership.query().where(
+            'profile_id',
+            profileId,
+        )
 
         /** Copy a list of the just the Groupings */
         const groupingIdsToGrab = allMemberships.map(
@@ -52,13 +55,13 @@ module.exports = class MembershipService extends Schmervice.Service {
 
     /**
      * Get a list of groupings for user
-     * @param {number} userId
+     * @param {number} profileId
      * @returns {Array}
      */
-    async findGroupingsById(userId) {
+    async findGroupingsById(profileId) {
         const { Grouping } = this.server.models()
 
-        const dedupedGroupings = await this._getGroupIdsForUserId(userId)
+        const dedupedGroupings = await this._getGroupIdsForProfileId(profileId)
 
         /** Grab just the Groupings this id has a Membership for */
         return await Grouping.query()
@@ -66,9 +69,11 @@ module.exports = class MembershipService extends Schmervice.Service {
             .whereIn('grouping_id', dedupedGroupings)
     }
 
-    async _groupingIdsInCommon(userId, targetId) {
-        const dedupedUserGroupingIds = await this._getGroupIdsForUserId(userId)
-        const dedupedTargetGroupingIds = await this._getGroupIdsForUserId(
+    async _groupingIdsInCommon(profileId, targetId) {
+        const dedupedUserGroupingIds = await this._getGroupIdsForProfileId(
+            profileId,
+        )
+        const dedupedTargetGroupingIds = await this._getGroupIdsForProfileId(
             targetId,
         )
 
@@ -77,24 +82,24 @@ module.exports = class MembershipService extends Schmervice.Service {
             dedupedTargetGroupingIds.includes(groupingId),
         )
     }
-    async _patchMembership(memberships, userId, patch) {
+    async _patchMembership(memberships, profileId, patch) {
         const { Membership } = this.server.models()
 
         /** Set membership as active only if the user initiates it */
         for (let membershipInfo of memberships) {
             await Membership.query()
                 .where('membership_id', membershipInfo.membership_id)
-                .where('user_id', userId)
+                .where('user_id', profileId)
                 .patch(patch)
         }
     }
 
-    async attemptMatch(userId, targetId) {
+    async attemptMatch(profileId, targetId) {
         const { Membership } = this.server.models()
 
         /** If both people have groups in common */
         const matchingGroupingIds = await this._groupingIdsInCommon(
-            userId,
+            profileId,
             targetId,
         )
 
@@ -106,7 +111,7 @@ module.exports = class MembershipService extends Schmervice.Service {
             )
 
             /** Set membership as active only if the user initiates it */
-            await this._patchMembership(memberships, userId, {
+            await this._patchMembership(memberships, profileId, {
                 is_active: true,
             })
 
@@ -121,18 +126,18 @@ module.exports = class MembershipService extends Schmervice.Service {
     /**
      * Check for grouping membership then add membership record and set to active
      * or create a new grouping and add membership record for user and membership record for target
-     * @param {number} userId
+     * @param {number} profileId
      * @param {number} targetId
      * @param {object} groupingToWrite
      * @param {string} role
      * @returns
      */
-    async joinGrouping(userId, targetId, groupingToWrite, role, txn) {
+    async joinGrouping(profileId, targetId, groupingToWrite, role, txn) {
         const { Membership } = this.server.models()
 
         /** If both people have groups in common */
         const matchingGroupingIds = await this._groupingIdsInCommon(
-            userId,
+            profileId,
             targetId,
         )
 
@@ -144,7 +149,7 @@ module.exports = class MembershipService extends Schmervice.Service {
             )
 
             /** Set membership as active only if the user initiates it */
-            await this._patchMembership(memberships, userId, {
+            await this._patchMembership(memberships, profileId, {
                 is_active: true,
             })
 
@@ -162,7 +167,7 @@ module.exports = class MembershipService extends Schmervice.Service {
             const groupingId = await this.findOrCreateGrouping(groupingToWrite)
 
             const userMembership = await Membership.query(txn).insert({
-                user_id: userId,
+                profile_id: profileId,
                 grouping_id: groupingId,
                 membership_type: role,
                 can_edit: false,
@@ -170,7 +175,7 @@ module.exports = class MembershipService extends Schmervice.Service {
             })
 
             const targetMembership = await Membership.query(txn).insert({
-                user_id: targetId,
+                profile_id: profileId,
                 grouping_id: groupingId,
                 membership_type: role,
                 can_edit: false,
@@ -183,14 +188,14 @@ module.exports = class MembershipService extends Schmervice.Service {
 
     /**
      * Remove membership record based on grouping_id
-     * @param {number} userId
+     * @param {number} profileId
      * @param {number} groupingId
      * @returns
      */
-    async leaveGrouping(userId, groupingId) {
+    async leaveGrouping(profileId, groupingId) {
         const { Membership } = this.server.models()
 
-        const dedupedGroupings = await this._getGroupIdsForUserId(userId)
+        const dedupedGroupings = await this._getGroupIdsForProfileId(profileId)
 
         /** Do NOTHING if NOT in Grouping */
         if (!dedupedGroupings.includes(groupingId)) return