:recycle: add error for missing sessionToken

backend/lib/routes/user/validate-session.js

@@ -31,12 +31,15 @@ module.exports = {
             const hashedSessionToken = request.payload
             const { userService, profileService } = request.server.services()
             try {
-                const validatedSessionToken =
+                const validatedSessionInfo =
                     userService.validateSession(hashedSessionToken)
-                if(validatedSessionToken?.email) throw new Error(`Could not validate token based on payload: ${request.payload}`)
-                
+                if (validatedSessionInfo?.email)
+                    throw new Error(
+                        `Could not validate token based on payload: ${request.payload}`,
+                    )
+
                 const user = await userService.findByUserEmail(
-                    validatedSessionToken.email,
+                    validatedSessionInfo.email,
                 )
                 const type = user.is_poster === 1 ? 'poster' : 'seeker'
                 const profiles = await profileService.getCompleteProfilesFor(
@@ -49,7 +52,7 @@ module.exports = {
                     ok: true,
                     handler: pluginConfig.handlerType,
                     data: {
-                        ...validatedSessionToken,
+                        ...validatedSessionInfo,
                         profileId: profileId,
                     },
                 }

backend/lib/services/user.js

@@ -266,10 +266,13 @@ module.exports = class UserService extends Schmervice.Service {
             throw new Error('email was never responded to!')
         }
         const sessionToken = userSession.sessionToken
+        if (!sessionToken) {
+            throw new Error('No session token in userSession')
+        }
         const sessionTokenIsValid = this.validateToken(sessionToken)
         return {
             ...sessionTokenIsValid.payload,
-            sessionToken: this.activeSessions[hashedSessionToken].sessionToken,
+            sessionToken,
             email: this.activeSessions[hashedSessionToken].email,
         }
     }