Przeglądaj źródła

:memo: Removed comments pertaining to refactor

tags/0.0.3^2
tomit4 3 lat temu
rodzic
commit
57b6465e69

+ 0
- 2
frontend/src/services/grouping.service.js Wyświetl plik

@@ -26,8 +26,6 @@ const fetchMembershipsByProfileId = async profileId => {
26 26
                     `/profile/${profileId}/tags/${grouping.grouping_id}`,
27 27
                 )
28 28
                 grouping.tags = [...targetTags, ...profileTags]
29
-                // NOTE: ref([]) allows to re render ChatView.vue revealed info upon reveal,
30
-                // but does not persist...
31 29
                 grouping.revealedFromNotification = ref([])
32 30
                 grouping._loading.value = false
33 31
                 validGroupingInstances.push(grouping)

+ 0
- 3
frontend/src/services/notification.service.js Wyświetl plik

@@ -58,9 +58,6 @@ class StonkAlert extends Toaster {
58 58
             const target_desc = parsed.description
59 59
             tagFromNotification[target_desc] = parsed.revealed_info
60 60
             foundGrouping.profile.reveal.push(tagFromNotification)
61
-            // NOTE: because revealedFromNotification is a ref() in
62
-            // grouping.service.js, ChatView.vue can render revealed info
63
-            // immediately, but will not persist
64 61
             foundGrouping.revealedFromNotification.value.push(tagFromNotification)
65 62
         }
66 63
     }

+ 0
- 5
frontend/src/views/ChatView.vue Wyświetl plik

@@ -15,19 +15,14 @@ main.view--chat
15 15
                 button(@click='reveal(8)') reveal my email
16 16
                 // TODO: Remove later, only for testing
17 17
                 button(@click='checkData()') check data
18
-            // TODO: Refactor, what if two people have the same name, etc.?
19
-            // NOTE: see notes in services/grouping.service.js and
20
-            // services/notification.service.js
21 18
             p you revealed:
22 19
                 span(v-if="grouping.revealed[profile.id.value]")
23 20
                     ul(v-for="reveal in grouping.revealed[profile.id.value]")
24 21
                         li {{ reveal.description }}: {{ profile._profile[reveal.description] }}
25 22
             p they revealed:
26
-            // BUG: persists, but doesn't display upon reveal
27 23
             span(v-if="grouping.revealed[target.profile_id]")
28 24
                 ul(v-for="reveal in grouping.revealed[target.profile_id]")
29 25
                     li {{ reveal.description }}: {{ target[reveal.description] }}
30
-            // BUG: reveals immediately, but does not persist
31 26
             ul(v-for="revealed in grouping.revealedFromNotification")
32 27
                 li(v-if="revealed[revealed.tag_description] !== profile._profile[revealed.tag_description]") {{ revealed.tag_description }}: {{ revealed[revealed.tag_description] }}
33 28
 

Ładowanie…
Anuluj
Zapisz