:recycle: refactor notification dispatching to a util

backend/lib/plugins/notification.js

@@ -1,3 +1,5 @@
+const { allStreams } = require('../utils')
+
 const NotificationRoute = require('../routes/notification')
 
 /** Heavily lifted from: https://github.com/mtharrison/susie/blob/master/lib/index.js */
@@ -8,8 +10,6 @@ const Transform = Stream.Transform
 
 const ENDER = { event: 'end', data: '' }
 
-const allStreams = {}
-
 /**
  * Stringify a stream
  * ?: I don't really get what this is doing

backend/lib/routes/membership/active.js

@@ -6,7 +6,7 @@ const errorSchema = require('../../schemas/errors')
 const groupingSchema = require('../../schemas/groupings')
 const params = require('../../schemas/params')
 
-const PassThrough = require('stream').PassThrough
+const { dispatchNotification } = require('../../utils')
 
 const pluginConfig = {
     handlerType: 'grouping',
@@ -36,19 +36,6 @@ const responseSchemas = {
     error: errorSchema.single,
 }
 
-const dispatch = (streamName, streams, h) => {
-    const stream = streams[streamName]
-    if (!stream || !streams) return
-    const msg = {
-        name: 'MSHRM',
-        price: (500 + Math.floor(Math.random() * 100)).toString(),
-        order: null,
-        type: 'info',
-    }
-    stream.write(msg)
-    h.event(stream, h, { event: streamName })
-}
-
 module.exports = {
     method: 'GET',
     path: '/{profile_id}',
@@ -96,9 +83,16 @@ module.exports = {
                 return g
             })
 
-            const allStreams =
-                request.server.plugins['notification-plugin']['streams']
-            dispatch(`${profileId}.stonk`, allStreams, h)
+            dispatchNotification(
+                {
+                    name: 'MSHRM',
+                    price: (500 + Math.floor(Math.random() * 100)).toString(),
+                    order: null,
+                    type: 'info',
+                },
+                `${profileId}.stonk`,
+                h,
+            )
 
             try {
                 return {

backend/lib/routes/notification/index.js

@@ -3,7 +3,7 @@ const apiSchema = require('../../schemas/api')
 const errorSchema = require('../../schemas/errors')
 const params = require('../../schemas/params')
 
-const PassThrough = require('stream').PassThrough
+const { intializeStream } = require('../../utils')
 
 const pluginConfig = {
     handlerType: 'notifictaion',
@@ -28,26 +28,11 @@ module.exports = {
         handler: async (request, h) => {
             const { profile_id } = request.params
 
-            const streamName = `${profile_id}.stonk`
-            const allStreams =
-                request.server.plugins['notification-plugin']['streams']
-            allStreams[streamName] = new PassThrough({ objectMode: true })
-
-            const msg = {
-                profile_id,
-                name: 'BDGRS',
-                price: (500 + Math.floor(Math.random() * 100)).toString(),
-                order: null,
-                type: 'info',
-            }
-
-            // Write to the input stream
-            msg.order = Math.floor(Math.random() * 2) === 1 ? 'BUY' : 'SELL'
-            allStreams[streamName].write(msg)
-
-            // h.event() Added at plugin registration
-            // h is the toolkit
-            return h.event(allStreams[streamName], h, { event: streamName })
+            /**
+             * Write the initial stream
+             * !: this must remain open for notifications to work
+             */
+            return intializeStream(`${profile_id}.stonk`, h)
         },
 
         /** Validate based on validators object */

backend/lib/utils.js

@@ -0,0 +1,43 @@
+const PassThrough = require('stream').PassThrough
+
+const allStreams = {}
+
+const activeStream = name => allStreams[name]
+
+/**
+ * Takes an open HTTP stream and writes
+ * a msg to it, then fires notification plugin's
+ * onEvent callback
+ * @param {object} msg you want to send
+ * @param {string} name <profileId>.<eventType>
+ * @param {object} req server request object
+ * @param {Toolkit} h hapi common response toolkit
+ */
+const dispatchNotification = (msg, name, h) => {
+    const stream = activeStream(name)
+    if (!stream) return
+    stream.write(msg)
+    return h.event(stream, h, { event: name })
+}
+
+const intializeStream = (name, h) => {
+    allStreams[name] = new PassThrough({ objectMode: true })
+
+    return dispatchNotification(
+        {
+            profile_id: name,
+            name: 'BDGRS',
+            price: (500 + Math.floor(Math.random() * 100)).toString(),
+            order: Math.floor(Math.random() * 2) === 1 ? 'BUY' : 'SELL',
+            type: 'info',
+        },
+        name,
+        h,
+    )
+}
+
+module.exports = {
+    dispatchNotification,
+    allStreams,
+    intializeStream,
+}