:recycle: tweaking endpoint to accept profile_id instead of passing with payload

backend/lib/routes/membership/join.js

@@ -9,8 +9,8 @@ const pluginConfig = {
 }
 
 const validators = {
+    params: Joi.object({ profile_id: Joi.number() }),
     payload: Joi.object({
-        profile_id: Joi.number().required(),
         target_id: Joi.number().required(),
         grouping_id: Joi.number().allow(null),
         grouping_name: Joi.string().allow(null),
@@ -31,7 +31,7 @@ const responseSchemas = {
 
 module.exports = {
     method: 'POST',
-    path: '/join',
+    path: '/{profile_id}/join',
     options: {
         ...pluginConfig.docs,
         tags: ['api'],
@@ -49,6 +49,7 @@ module.exports = {
                 const { membershipService } = request.server.services()
 
                 /** Grab payload info */
+                const profileId = request.params.profile_id
                 const res = request.payload
                 const groupingToWrite = {
                     grouping_id: res.grouping_id,
@@ -59,10 +60,14 @@ module.exports = {
                 /** Default to participant role */
                 const role = res.role ? res.role : 'participant'
 
+                // TODO: LIMIT the amount of groupings by checking type
+                // !: You should only be able to match with the target_id ONCE
+                // !: You should only be associated with a single company too
                 console.log('---')
+
                 /** User membership service method to create membership */
                 const memberships = await membershipService.joinGrouping(
-                    res.profile_id,
+                    profileId,
                     res.target_id,
                     groupingToWrite,
                     role,

frontend/src/App.vue

@@ -69,7 +69,7 @@ export default {
             }
             console.log(groupings)
             groupings = []
-            await postMembershipByProfileId({ profileId: 1, targetId: 20 })
+            await postMembershipByProfileId({ profileId: 1, targetId: 22 })
             for(let p of tempProfiles) {
                 const memberships = await fetchMembershipsByProfileId(p.profile_id)
                 groupings.push(memberships)

frontend/src/services/grouping.service.js

@@ -22,13 +22,11 @@ const fetchMembershipsByProfileId = async profileId => {
 
 const postMembershipByProfileId = async ({ profileId, targetId, groupingType = 'match' }) => {
     const membership = {
-        profile_id: profileId,
         target_id: targetId,
         grouping_type: groupingType,
         grouping_name: `delete_${profileId}_${targetId}`
     }
-    const createdMembershipRecord = await db.post(`/membership/join`, membership)
-    console.log(createdMembershipRecord)
+    const createdMembershipRecord = await db.post(`/membership/${profileId}/join`, membership)
     return createdMembershipRecord
 }
 export { fetchMembershipsByProfileId, postMembershipByProfileId }