reverting to always notify

backend/lib/routes/membership/join.js

@@ -31,25 +31,6 @@ const responseSchemas = {
     error: errorSchema.single,
 }
 
-const notifyMembers = (profileId, targetId, noticationCb, h) => {
-    noticationCb(
-        `${profileId}.stonk`,
-        {
-            name: `${targetId} Match Fffound`,
-            type: 'info',
-        },
-        h,
-    )
-    noticationCb(
-        `${targetId}.stonk`,
-        {
-            name: `${profileId} Match Fffound`,
-            type: 'info',
-        },
-        h,
-    )
-}
-
 module.exports = {
     method: 'POST',
     path: '/{profile_id}/join',
@@ -92,18 +73,29 @@ module.exports = {
                     groupingToWrite,
                     role,
                 )
-
+                // console.log(memberships)
                 const hasMatch = memberships.every(
-                    membership => membership.is_active == true,
+                    membership => membership && membership.is_active == true,
                 )
-                if (hasMatch) {
-                    notifyMembers(
-                        profileId,
-                        res.target_id,
-                        request.server.notify,
-                        h,
-                    )
-                }
+                request.server.methods.notify(
+                    `${profileId}.stonk`,
+                    {
+                        name: `${res.target_id} Match Fffound`,
+                        type: 'info',
+                    },
+                    h,
+                )
+                request.server.methods.notify(
+                    `${res.target_id}.stonk`,
+                    {
+                        name: `${profileId} Match Fffound`,
+                        type: 'info',
+                    },
+                    h,
+                )
+                console.log('hasMatch :>> ', hasMatch)
+                console.log('memberships :>> ', memberships)
+
                 return h
                     .response({
                         ok: true,

backend/lib/routes/profile/patch-queue.js

@@ -16,7 +16,7 @@ const pluginConfig = {
 
 const responseSchemas = {
     response: Joi.array().items(
-        Joi.alternatives().try(Joi.number(), profileSchema.single),
+        Joi.alternatives().try(Joi.number().optional(), profileSchema.single),
     ),
     error: errorSchema.single,
 }
@@ -55,6 +55,7 @@ module.exports = {
             if (include_profile) {
                 res.data = await profileService.getProfilesFor(queueIds)
             }
+
             try {
                 return h.response(res).code(200)
             } catch (err) {

backend/lib/schemas/responses.js

@@ -18,7 +18,9 @@ const singleResponseKey = Joi.object({
 
 module.exports = {
     single: singleResponse,
-    list: Joi.array().items(singleResponse).label('response_list'),
+    list: Joi.array().items(singleResponse.optional()).label('response_list'),
     key: singleResponseKey,
-    keys: Joi.array().items(singleResponseKey).label('question_list')
+    keys: Joi.array()
+        .items(singleResponseKey.optional())
+        .label('question_list'),
 }