:lipstick: Adjusted naming for readability

frontend/src/utils/survey.js

@@ -6,13 +6,15 @@ class SurveyFactory {
     constructor() {
         this.questionsFromDb = []
     }
-    _addResponses(responseKeys, possibleResponsesByCategory) {
+    _addResponses(responseKeys, responsesByCategory) {
         const validFormInputs = {}
-        Object.keys(possibleResponsesByCategory).forEach(categoryKey => {
-            if (possibleResponsesByCategory[categoryKey].length) {
-                validFormInputs[categoryKey] = possibleResponsesByCategory[categoryKey]
+        // Removes empty form drop down options from possible['usa']
+        Object.keys(responsesByCategory).forEach(categoryKey => {
+            if (responsesByCategory[categoryKey].length) {
+                validFormInputs[categoryKey] = responsesByCategory[categoryKey]
             }
         })
+        // Adds form drop down options to each responseKey
         Object.keys(validFormInputs).forEach(inputKey => {
             responseKeys.forEach(responseKey => {
                 if (responseKey.survey_stage == inputKey) {
@@ -23,16 +25,16 @@ class SurveyFactory {
         return responseKeys
     }
     _addComponents(responseKeys) {
-        responseKeys.forEach(key => {
-            switch (key.category) {
+        responseKeys.forEach(responseKey => {
+            switch (responseKey.category) {
                 case 'input':
-                    key.component = 'FormInput'
+                    responseKey.component = 'FormInput'
                     break
                 case 'choice':
-                    key.component = 'FormDropdown'
+                    responseKey.component = 'FormDropdown'
                     break
                 case 'aspect':
-                    key.component = 'QuestionResponse'
+                    responseKey.component = 'QuestionResponse'
                     break
             }
         })
@@ -52,10 +54,10 @@ class SurveyFactory {
     _sortSurveySteps(mutatedResponseKeys, allSteps) {
         const reordered = []
         Object.values(allSteps).forEach(step => {
-            Object.values(mutatedResponseKeys).forEach(val => {
-                if (surveyStages[val.response_key_id] === step)  {
-                    val.survey_stage = step
-                    reordered.push(val)
+            Object.values(mutatedResponseKeys).forEach(response => {
+                if (surveyStages[response.response_key_id] === step)  {
+                    response.survey_stage = step
+                    reordered.push(response)
                 }
             })
         })