:bug: include empty in taxonomy term array

plugins/cia-endpoints/includes/class.make-sortby.php

@@ -39,7 +39,7 @@ class Make_Sort_By extends WP_REST_Controller {
     function make_terms_array($taxonomy, $field) {
         $terms = get_terms([
             'taxonomy'   => $taxonomy,
-            'hide_empty' => true,
+            'hide_empty' => false,
             'fields'     => $field
         ]);
         return $terms;

plugins/cia-post-types/includes/p2p-mappings.php

@@ -18,21 +18,10 @@ function register_connections_for($type, $from_types) {
         ]);
     }
 }
+
 function register_all_one_offs() {
-    p2p_register_connection_type([
-        'name' => 'artists_to_artists',
-        'to' => 'artist',
-        'from' => 'artist',
-        'reciprocal' => true,
-        'admin_box' => $admin_box
-    ]);
-    p2p_register_connection_type([
-        'name' => 'shorts_to_techniques',
-        'to' => 'short',
-        'from' => 'technique',
-        'reciprocal' => true,
-        'admin_box' => $admin_box
-    ]);
+    register_connections_for('artist', ['artist']);
+    register_connections_for('short', ['technique']);
 }
 
 function all_connection_types() {