:recycle: refactor how p2p rels are created

plugins/cia-post-types/includes/p2p-mappings.php

@@ -6,14 +6,19 @@ $admin_box = [
     'context' => 'side'
 ];
 
-function all_connection_types() {
-    p2p_register_connection_type([
-        'name' => 'artists_to_episodes',
-        'to' => 'artist',
-        'from' => 'episode',
-        'reciprocal' => true,
-        'admin_box' => $admin_box
-    ]);
+function register_connections_for($type, $from_types) {
+    foreach($from_types as $f_type) {
+        $name = $type . 's_to_' . $f_type . 's';
+        p2p_register_connection_type([
+            'name' => $name,
+            'to' => $type,
+            'from' => $f_type,
+            'reciprocal' => true,
+            'admin_box' => $admin_box
+        ]);
+    }
+}
+function register_all_one_offs() {
     p2p_register_connection_type([
         'name' => 'artists_to_artists',
         'to' => 'artist',
@@ -22,107 +27,44 @@ function all_connection_types() {
         'admin_box' => $admin_box
     ]);
     p2p_register_connection_type([
-        'name' => 'artists_to_exhibitions',
-        'to' => 'artist',
-        'from' => 'exhibition',
-        'reciprocal' => true,
-        'admin_box' => $admin_box
-    ]);
-    p2p_register_connection_type([
-        'name' => 'artists_to_events',
-        'to' => 'artist',
-        'from' => 'event',
-        'reciprocal' => true,
-        'admin_box' => $admin_box
-    ]);
-    p2p_register_connection_type([
-        'name' => 'artists_to_posts',
-        'to' => 'artist',
-        'from' => 'post',
-        'reciprocal' => true,
-        'admin_box' => $admin_box
-    ]);
-    p2p_register_connection_type([
-        'name' => 'artists_to_shorts',
-        'to' => 'artist',
-        'from' => 'short',
-        'reciprocal' => true,
-        'admin_box' => $admin_box
-    ]);
-    p2p_register_connection_type([
-        'name' => 'artists_to_techniques',
-        'to' => 'artist',
+        'name' => 'shorts_to_techniques',
+        'to' => 'short',
         'from' => 'technique',
         'reciprocal' => true,
         'admin_box' => $admin_box
     ]);
+}
 
-    p2p_register_connection_type([
-        'name' => 'episodes_to_exhibitions',
-        'to' => 'episode',
-        'from' => 'exhibition',
-        'reciprocal' => true,
-        'admin_box' => $admin_box
-    ]);
-    p2p_register_connection_type([
-        'name' => 'episodes_to_events',
-        'to' => 'episode',
-        'from' => 'event',
-        'reciprocal' => true,
-        'admin_box' => $admin_box
-    ]);
-    p2p_register_connection_type([
-        'name' => 'episodes_to_posts',
-        'to' => 'episode',
-        'from' => 'post',
-        'reciprocal' => true,
-        'admin_box' => $admin_box
-    ]);
-    p2p_register_connection_type([
-        'name' => 'episodes_to_shorts',
-        'to' => 'episode',
-        'from' => 'short',
-        'reciprocal' => true,
-        'admin_box' => $admin_box
-    ]);
-    p2p_register_connection_type([
-        'name' => 'episodes_to_techniques',
-        'to' => 'episode',
-        'from' => 'technique',
-        'reciprocal' => true,
-        'admin_box' => $admin_box
-    ]);
+function all_connection_types() {
+    $connection_stack = [
+        'artist',
+        'episode',
+        'event',
+        'exhibition',
+        'post',
+        'guide',
+        'short',
+        'technique',
+    ];
 
-    p2p_register_connection_type([
-        'name' => 'events_to_exhibitions',
-        'to' => 'event',
-        'from' => 'exhibition',
-        'reciprocal' => true,
-        'admin_box' => $admin_box
-    ]);
-    p2p_register_connection_type([
-        'name' => 'events_to_posts',
-        'to' => 'event',
-        'from' => 'post',
-        'reciprocal' => true,
-        'admin_box' => $admin_box
-    ]);
+    // Kick-off by assigning to artist
+    $artist = array_shift($connection_stack);
+    register_connections_for($artist, $connection_stack);
+    $episode = array_shift($connection_stack);
+    register_connections_for($episode, $connection_stack);
     
-    p2p_register_connection_type([
-        'name' => 'exhibitions_to_posts',
-        'to' => 'exhibition',
-        'from' => 'post',
-        'reciprocal' => true,
-        'admin_box' => $admin_box
-    ]);
-
-    p2p_register_connection_type([
-        'name' => 'shorts_to_techniques',
-        'to' => 'short',
-        'from' => 'technique',
-        'reciprocal' => true,
-        'admin_box' => $admin_box
-    ]);
+    /** Pop the end for now... */ 
+    $technique = array_pop($connection_stack);
+    $short = array_pop($connection_stack);
+    $guide = array_pop($connection_stack);
+    
+    // Remaining: ['event', 'exhibition', 'post']
+    $event = array_shift($connection_stack);
+    register_connections_for($event, $connection_stack);
+    $exhibition = array_shift($connection_stack);
+    register_connections_for($exhibition, $connection_stack);
+    
+    register_all_one_offs();
 }
 add_action( 'p2p_init', 'all_connection_types' );